-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #38
Testing #38
Conversation
b766452
to
484e18a
Compare
The CPP Tests are failing becuase the wrong path is in It should always point to the src dir |
9cf60aa
to
889dbbf
Compare
What is the status of this PR, @tanneberger? |
@lhstrh Last Thing I did this weekend was looking into why the typescript CI is still red, and I think its the dockerized tests. |
Okay, the next problem with the typescript target is that the federated code gen is dropped under |
Yes, it is. The |
@lhstrh Would it be possible to rename No, there is an src-gen in fed-gen subtree for each federate as well. It is different from the src-gen in the root. |
62f42a7
to
39ad982
Compare
87eb2a6
to
24e5bb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I think we should address the remaining Clippy warnings before merging though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was only able to do a spot check because I'm not a Rust expert, but this looks good to me!
Things Done
keep-alive
flagFuture Work
Fixes #42.